Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve gentx validation & error messages #11500

Merged
merged 14 commits into from
Mar 31, 2022
Merged

fix: Improve gentx validation & error messages #11500

merged 14 commits into from
Mar 31, 2022

Conversation

anilcse
Copy link
Collaborator

@anilcse anilcse commented Mar 30, 2022

Description

Closes: #9304

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:x/genutil genutil module issues label Mar 30, 2022
@likhita-809 likhita-809 changed the title Add validate gentx, debug error messages fix: Add validate gentx, debug error messages Mar 30, 2022
@anilcse anilcse changed the title fix: Add validate gentx, debug error messages fix: Improve gentx validation & error messages Mar 30, 2022
michaelfig
michaelfig approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it provides the expected specific panics instead of generic panics. Thanks!

amaury1093
amaury1093 approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Let's also add a changelog message

atheeshp
atheeshp approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

alexanderbez
alexanderbez approved these changes Mar 30, 2022
View reviewed changes
x/genutil/types/genesis_state.go Show resolved Hide resolved
x/genutil/types/genesis_state.go Outdated Show resolved Hide resolved
x/genutil/types/genesis_state.go Outdated Show resolved Hide resolved
x/genutil/types/genesis_state.go Outdated Show resolved Hide resolved
x/genutil/gentx.go Outdated Show resolved Hide resolved
x/genutil/gentx.go Outdated Show resolved Hide resolved
x/genutil/gentx.go Outdated Show resolved Hide resolved
robert-zaremba
robert-zaremba reviewed Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's return errors instead of panicing. The function signature already supports that

x/genutil/gentx.go Outdated Show resolved Hide resolved
x/genutil/gentx.go Outdated Show resolved Hide resolved
anilcse and others added 7 commits March 30, 2022 22:30
@anilcse @alexanderbez
Update x/genutil/gentx.go
bfa51af 
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@anilcse @alexanderbez
Update x/genutil/gentx.go
14f9209 
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@anilcse @alexanderbez
Update x/genutil/gentx.go
465b83b 
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@anilcse @alexanderbez
Update x/genutil/types/genesis_state.go
fda9a47 
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@anilcse @alexanderbez
Update x/genutil/types/genesis_state.go
9193d8e 
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@anilcse @alexanderbez
Update x/genutil/types/genesis_state.go
7662bab 
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@anilcse
Add godoc
bbf1d24
@anilcse
Copy link
Collaborator Author

anilcse commented Mar 31, 2022

@robert-zaremba updated the PR, can you please take a final review

robert-zaremba
robert-zaremba approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@anilcse anilcse added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 31, 2022
@mergify mergify bot merged commit a4d46ff into master Mar 31, 2022
@mergify mergify bot deleted the anil/gentx_validation branch March 31, 2022 20:13
@amaury1093 amaury1093 mentioned this pull request May 20, 2022
Closed
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atheeshp atheeshp atheeshp approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@michaelfig michaelfig michaelfig approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@kaustubhkapatral kaustubhkapatral Awaiting requested review from kaustubhkapatral

Assignees

@amaury1093 amaury1093

@atheeshp atheeshp

Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/genutil genutil module issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid gentx causes hard-to-diagnose errors
6 participants
@anilcse @michaelfig @robert-zaremba @amaury1093 @alexanderbez @atheeshp